Sealedoff #1
Closed
Sealedoff #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 5, 2018 15:24
…, to seal them off.
- removed all global variables (GUIs and fonts). They must now be set once using a function. - removed export on ItemGiven and created an accessor instead. - Similarly, added an accessor on UsedAction
…r Save, one for Load and one for Options - I have removed global variables from the Options script : the fonts and the GUIs must now be set externally, in TemplateSettings - I have moved "Offset" and "Distance" to a utility class
|
@jeancallisti , something I noticed: #ifndef __OPTION_GUI_MODULE__ //a dependency is missing
void game_start()
{
AbortGame("Missing module 'OptionGui'");
}
#endif
You could instead use #error command like #ifndef __OPTION_GUI_MODULE__ //a dependency is missing
#error Missing module 'OptionGui'
#endif
This will report error at compile time. |
added 4 commits
August 9, 2018 15:00
- added reminders to remove references to gMain - fixed some references to global variables that I overlooked in previous commits
…data independently frm their current state - made it possible to setup the buttons and their graphics outside of the module for better integration with larger code base
- Made function Verbs::GetButtonAction more robust (had issues dealing with action 0) - Made most enums start at value 0 instead of 1, to avoid a "dead" value at the beginning of iterations
|
This pull request has some issues. Also in your branch the functions dropdown in the AGS Editor doesn't work anymore, or it least it can't show any functions. |
dkrey
added a commit
that referenced
this pull request
Nov 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch focuses on "sealing off" this module's script from the global script and from the game.
The goal is to make this module less dependant on any global data from the game.
Specifically :
Additionally to that, some (moderate) effort is put into gathering global variables from the modules' scripts into objects (structs), as members. This achieves two things : 1) This acts like a primitive namespace (you know instantly where the variables come from), 2) This certifies that there are no unexepected "export" of variables.